-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(build): hermetic install of files after build #12882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Apr 19, 2024
fffonion
force-pushed
the
bazel-install
branch
2 times, most recently
from
April 19, 2024 00:48
bece329
to
13a5b62
Compare
github-actions
bot
added
the
chore
Not part of the core functionality of kong, but still needed
label
Apr 19, 2024
fffonion
force-pushed
the
bazel-install
branch
6 times, most recently
from
April 19, 2024 03:24
bf3e516
to
be904bb
Compare
ADD-SP
reviewed
Apr 19, 2024
ADD-SP
reviewed
Apr 19, 2024
outsinre
reviewed
Apr 22, 2024
outsinre
reviewed
Apr 22, 2024
fffonion
force-pushed
the
bazel-install
branch
5 times, most recently
from
April 22, 2024 14:27
2b6950f
to
cb1b021
Compare
outsinre
approved these changes
Apr 23, 2024
fffonion
force-pushed
the
bazel-install
branch
3 times, most recently
from
April 25, 2024 11:52
d49b409
to
ba8774d
Compare
fffonion
force-pushed
the
bazel-install
branch
2 times, most recently
from
May 6, 2024 03:35
bbc175b
to
56fb9f9
Compare
fffonion
changed the title
fix(build): hermetic install of files after build
refactor(build): hermetic install of files after build
May 13, 2024
ADD-SP
approved these changes
May 13, 2024
Water-Melon
approved these changes
May 13, 2024
fffonion
force-pushed
the
bazel-install
branch
2 times, most recently
from
May 15, 2024 08:25
5926569
to
02badc6
Compare
directory for openresty build for development
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
May 15, 2024
This was cherrypicked in https://github.com/Kong/kong-ee/pull/8843 |
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
size/XL
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the giant bash blob in
//build:kong
target to Bazel rules that each output files are tracked. So that:copy_with_filter
when install.//build:install-xx
target to only build and install selectd components, like//build:install-openresty
only install openresty and openssl and skip luarocks etc.Other noticable changes:
//build:dev-make-openresty
target is added so that developer can use it to invokemake
directly for openresty development.PREFIX/openresty/site/lualib
where typically PREFIX is/usr/local
. This is to avoid collide with openresty bundled files (PREFIX/openresty/lualib), where those files used to be installed under.v1.6.1
atc-router#216KAG-4290
Needs Kong/atc-router#219